Request Call placeholder & messages updated #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chiragsalian for the new messages text alignment looks odd. |
|
Good point. I think the error message should maybe be center-aligned. But it's better to rope in design for this so cc-ing @Expensify/design for thoughts/suggestions on how the error message should appear. |
|
I think the left-alignment is fine as it is. |
|
@chiragsalian bump! |
|
Seems the design team is okay with this! |
chiragsalian
requested changes
Nov 8, 2021
|
Will update the PR & let you know |
|
Updated PR |
|
@chiragsalian PR updated |
chiragsalian
approved these changes
Nov 11, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.15-18 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Just place holder & phone number error message copy updates for Request a Call Modal.
Fixed Issues
$ #5945
Tests & QA Steps
2109400803callwithout entering any number to check the new error messages.Tested On
Screenshots
Web
Mobile Web
iOS
Android
Desktop